Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed)

Created:
7 years, 7 months ago by Ryan Sleevi
Modified:
7 years, 7 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, tzik+watch_chromium.org, rsesek+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, cbentzel+watch_chromium.org, vsevik, ben+watch_chromium.org, jam, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, tim (not reviewing), Raghu Simha, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, haitaol1, chrome-apps-syd-reviews_chromium.org, akalin, tfarina, yurys, Aaron Boodman, davemoore+watch_chromium.org, cc-bugs_chromium.org, pfeldman
Visibility:
Public.

Description

Warn on missing OVERRIDE/virtual everywhere, not just in header files. This is only enabled for Linux (so far). BUG=115047 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197788

Patch Set 1 #

Total comments: 1

Patch Set 2 : Don't warn for Linux+chromeos==1 builds #

Patch Set 3 : new regressions, attempt 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -178 lines) Patch
M ash/launcher/launcher_button.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/shell/app_list.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/partial_screenshot_view_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/debug/trace_event_impl.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M build/common.gypi View 1 1 chunk +21 lines, -2 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_security_exploit_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/cert_library.cc View 1 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/net/connectivity_state_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 1 chunk +7 lines, -9 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/audio/audio_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/signin/oauth2_token_service_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/global_error/global_error_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/features/base_feature_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/devtools_event_logger_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/experimental_bluetooth_adapter_client.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M chromeos/dbus/experimental_bluetooth_device_client.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M chromeos/display/output_configurator_unittest.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chromeos/ime/component_extension_ime_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/browser/autofill_data_model_unittest.cc View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/smooth_scroll_gesture_controller_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/dom_operations_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/dom_serializer_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/resource_fetcher_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/object_manager_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/congestion_control/available_channel_estimator_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/channel_estimator_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/inter_arrival_bitrate_ramp_up_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/inter_arrival_sender_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/inter_arrival_state_machine_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_framer_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 1 chunk +23 lines, -15 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/parent_child_index_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/plugin_flags.sh View 1 chunk +1 line, -3 lines 0 comments Download
M ui/app_list/views/app_list_menu_views.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/image/image.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/message_center/views/message_center_view_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/corewm/focus_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/copy_or_move_file_validator_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Sleevi
Darin: Mind rubberstamping this global clean-up? This just uses fixits for Linux build. The change ...
7 years, 7 months ago (2013-05-01 00:14:55 UTC) #1
darin (slow to review)
LGTM
7 years, 7 months ago (2013-05-01 05:33:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/14696007/5001
7 years, 7 months ago (2013-05-01 19:53:54 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-01 20:24:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/14696007/22001
7 years, 7 months ago (2013-05-01 23:26:31 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-02 02:24:15 UTC) #6
Message was sent while issue was closed.
Change committed as 197788

Powered by Google App Engine
This is Rietveld 408576698