chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc

diff --git a/chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc b/chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc

index 16207e4ca3c881573a13a6458a1345251f8b00cf..5297f3b8624add298d5c6dcb5f8bd2b1a599e6de 100644

--- a/chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc

+++ b/chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc

@@ -32,7 +32,7 @@ class BrowserProcessDetails : public MemoryDetails {

typedef base::Callback<void(const ProcessData&)> DataCallback;

explicit BrowserProcessDetails(const DataCallback& callback)

: callback_(callback) {}

- virtual void OnDetailsAvailable() {

+ virtual void OnDetailsAvailable() OVERRIDE {

const std::vector<ProcessData>& browser_processes = processes();

callback_.Run(browser_processes[0]);

}