Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1925)

Unified Diff: ash/shell/app_list.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf_widget.cc ('k') | ash/wm/partial_screenshot_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shell/app_list.cc
diff --git a/ash/shell/app_list.cc b/ash/shell/app_list.cc
index 9afee4fab169001a8c79ef906f0b7ad837c04232..7ee4d388b1cd2f87d90109dd9815ebb403f5697d 100644
--- a/ash/shell/app_list.cc
+++ b/ash/shell/app_list.cc
@@ -295,19 +295,19 @@ class ExampleAppListViewDelegate : public app_list::AppListViewDelegate {
return gfx::ImageSkia();
}
- virtual base::string16 GetCurrentUserName() {
+ virtual base::string16 GetCurrentUserName() OVERRIDE {
return base::string16();
}
- virtual base::string16 GetCurrentUserEmail() {
+ virtual base::string16 GetCurrentUserEmail() OVERRIDE {
return base::string16();
}
- virtual void OpenSettings() {
+ virtual void OpenSettings() OVERRIDE {
// Nothing needs to be done.
}
- virtual void OpenFeedback() {
+ virtual void OpenFeedback() OVERRIDE {
// Nothing needs to be done.
}
« no previous file with comments | « ash/shelf/shelf_widget.cc ('k') | ash/wm/partial_screenshot_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698