Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: ash/wm/partial_screenshot_view_unittest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shell/app_list.cc ('k') | base/debug/trace_event_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/partial_screenshot_view_unittest.cc
diff --git a/ash/wm/partial_screenshot_view_unittest.cc b/ash/wm/partial_screenshot_view_unittest.cc
index ea1d54c111fe28a7226c76f1c71bfabcdca985e1..a763577d0ef935e735ee5a0ebc39f6be582198cb 100644
--- a/ash/wm/partial_screenshot_view_unittest.cc
+++ b/ash/wm/partial_screenshot_view_unittest.cc
@@ -17,14 +17,14 @@ class FakeScreenshotDelegate : public ScreenshotDelegate {
public:
FakeScreenshotDelegate() : screenshot_count_(0) {}
- void HandleTakeScreenshotForAllRootWindows() OVERRIDE {}
- void HandleTakePartialScreenshot(aura::Window* window,
- const gfx::Rect& rect) OVERRIDE {
+ virtual void HandleTakeScreenshotForAllRootWindows() OVERRIDE {}
+ virtual void HandleTakePartialScreenshot(aura::Window* window,
+ const gfx::Rect& rect) OVERRIDE {
rect_ = rect;
screenshot_count_++;
}
- bool CanTakeScreenshot() OVERRIDE {
+ virtual bool CanTakeScreenshot() OVERRIDE {
return true;
}
« no previous file with comments | « ash/shell/app_list.cc ('k') | base/debug/trace_event_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698