Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: base/debug/trace_event_impl.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/partial_screenshot_view_unittest.cc ('k') | build/common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/trace_event_impl.cc
diff --git a/base/debug/trace_event_impl.cc b/base/debug/trace_event_impl.cc
index ba264cd8311b186698fbebbda13769aed4712548..e1d4a4c98f31564189336811294eb64ab5455c1e 100644
--- a/base/debug/trace_event_impl.cc
+++ b/base/debug/trace_event_impl.cc
@@ -232,24 +232,25 @@ class TraceBufferDiscardsEvents : public TraceBuffer {
public:
virtual ~TraceBufferDiscardsEvents() { }
- virtual void AddEvent(const TraceEvent& event) { }
- virtual bool HasMoreEvents() const { return false; }
+ virtual void AddEvent(const TraceEvent& event) OVERRIDE {}
+ virtual bool HasMoreEvents() const OVERRIDE { return false; }
- virtual const TraceEvent& NextEvent() {
+ virtual const TraceEvent& NextEvent() OVERRIDE {
NOTREACHED();
return *static_cast<TraceEvent*>(NULL);
}
- virtual bool IsFull() const { return false; }
+ virtual bool IsFull() const OVERRIDE { return false; }
- virtual size_t CountEnabledByName(const unsigned char* category,
- const std::string& event_name) const {
+ virtual size_t CountEnabledByName(
+ const unsigned char* category,
+ const std::string& event_name) const OVERRIDE {
return 0;
}
- virtual size_t Size() const { return 0; }
+ virtual size_t Size() const OVERRIDE { return 0; }
- virtual const TraceEvent& GetEventAt(size_t index) const {
+ virtual const TraceEvent& GetEventAt(size_t index) const OVERRIDE {
NOTREACHED();
return *static_cast<TraceEvent*>(NULL);
}
« no previous file with comments | « ash/wm/partial_screenshot_view_unittest.cc ('k') | build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698