Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: chromeos/ime/component_extension_ime_manager_unittest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 #include "chromeos/ime/component_extension_ime_manager.h" 6 #include "chromeos/ime/component_extension_ime_manager.h"
7 #include "chromeos/ime/extension_ime_util.h" 7 #include "chromeos/ime/extension_ime_util.h"
8 #include "chromeos/ime/mock_component_extension_ime_manager_delegate.h" 8 #include "chromeos/ime/mock_component_extension_ime_manager_delegate.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 10 matching lines...) Expand all
21 21
22 class ComponentExtensionIMEManagerTest : 22 class ComponentExtensionIMEManagerTest :
23 public testing::Test, 23 public testing::Test,
24 public ComponentExtensionIMEManager::Observer { 24 public ComponentExtensionIMEManager::Observer {
25 public: 25 public:
26 ComponentExtensionIMEManagerTest() 26 ComponentExtensionIMEManagerTest()
27 : mock_delegate_(NULL), 27 : mock_delegate_(NULL),
28 on_initialized_callcount_(0) { 28 on_initialized_callcount_(0) {
29 } 29 }
30 30
31 void SetUp() { 31 virtual void SetUp() {
32 ime_list_.clear(); 32 ime_list_.clear();
33 33
34 ComponentExtensionIME ext1; 34 ComponentExtensionIME ext1;
35 ext1.id = "ext1_id"; 35 ext1.id = "ext1_id";
36 ext1.description = "ext1_description"; 36 ext1.description = "ext1_description";
37 ext1.options_page_url = "chrome-extension://" + ext1.id + "/options.html"; 37 ext1.options_page_url = "chrome-extension://" + ext1.id + "/options.html";
38 ext1.path = base::FilePath("ext1_file_path"); 38 ext1.path = base::FilePath("ext1_file_path");
39 39
40 ComponentExtensionEngine ext1_engine1; 40 ComponentExtensionEngine ext1_engine1;
41 ext1_engine1.engine_id = "ext1_engine1_engine_id"; 41 ext1_engine1.engine_id = "ext1_engine1_engine_id";
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 component_ext_mgr_.reset(new ComponentExtensionIMEManager()); 122 component_ext_mgr_.reset(new ComponentExtensionIMEManager());
123 component_ext_mgr_->AddObserver(this); 123 component_ext_mgr_->AddObserver(this);
124 EXPECT_FALSE(component_ext_mgr_->IsInitialized()); 124 EXPECT_FALSE(component_ext_mgr_->IsInitialized());
125 component_ext_mgr_->Initialize( 125 component_ext_mgr_->Initialize(
126 scoped_ptr<ComponentExtensionIMEManagerDelegate>( 126 scoped_ptr<ComponentExtensionIMEManagerDelegate>(
127 mock_delegate_).Pass()); 127 mock_delegate_).Pass());
128 EXPECT_TRUE(component_ext_mgr_->IsInitialized()); 128 EXPECT_TRUE(component_ext_mgr_->IsInitialized());
129 129
130 } 130 }
131 131
132 void TearDown() { 132 virtual void TearDown() {
133 EXPECT_EQ(1, on_initialized_callcount_); 133 EXPECT_EQ(1, on_initialized_callcount_);
134 component_ext_mgr_->RemoveObserver(this); 134 component_ext_mgr_->RemoveObserver(this);
135 } 135 }
136 136
137 protected: 137 protected:
138 MockComponentExtIMEManagerDelegate* mock_delegate_; 138 MockComponentExtIMEManagerDelegate* mock_delegate_;
139 scoped_ptr<ComponentExtensionIMEManager> component_ext_mgr_; 139 scoped_ptr<ComponentExtensionIMEManager> component_ext_mgr_;
140 std::vector<ComponentExtensionIME> ime_list_; 140 std::vector<ComponentExtensionIME> ime_list_;
141 141
142 private: 142 private:
143 void OnInitialized() { 143 virtual void OnInitialized() OVERRIDE {
144 ++on_initialized_callcount_; 144 ++on_initialized_callcount_;
145 } 145 }
146 146
147 int on_initialized_callcount_; 147 int on_initialized_callcount_;
148 148
149 DISALLOW_COPY_AND_ASSIGN(ComponentExtensionIMEManagerTest); 149 DISALLOW_COPY_AND_ASSIGN(ComponentExtensionIMEManagerTest);
150 }; 150 };
151 151
152 TEST_F(ComponentExtensionIMEManagerTest, LoadComponentExtensionIMETest) { 152 TEST_F(ComponentExtensionIMEManagerTest, LoadComponentExtensionIMETest) {
153 for (size_t i = 0; i < ime_list_.size(); ++i) { 153 for (size_t i = 0; i < ime_list_.size(); ++i) {
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 for (size_t i = 0; i < ime_list_.size(); ++i) { 250 for (size_t i = 0; i < ime_list_.size(); ++i) {
251 total_ime_size += ime_list_[i].engines.size(); 251 total_ime_size += ime_list_[i].engines.size();
252 } 252 }
253 EXPECT_EQ(total_ime_size, descriptors.size()); 253 EXPECT_EQ(total_ime_size, descriptors.size());
254 } 254 }
255 255
256 } // namespace 256 } // namespace
257 257
258 } // namespace input_method 258 } // namespace input_method
259 } // namespace chromeos 259 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/display/output_configurator_unittest.cc ('k') | components/autofill/browser/autofill_data_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698