Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: build/common.gypi

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/debug/trace_event_impl.cc ('k') | cc/resources/tile_manager_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 1508 matching lines...) Expand 10 before | Expand all | Expand 10 after
1519 ['enable_settings_app==1', { 1519 ['enable_settings_app==1', {
1520 'grit_defines': ['-D', 'enable_settings_app'], 1520 'grit_defines': ['-D', 'enable_settings_app'],
1521 }], 1521 }],
1522 ['enable_google_now==1', { 1522 ['enable_google_now==1', {
1523 'grit_defines': ['-D', 'enable_google_now'], 1523 'grit_defines': ['-D', 'enable_google_now'],
1524 }], 1524 }],
1525 ['use_concatenated_impulse_responses==1', { 1525 ['use_concatenated_impulse_responses==1', {
1526 'grit_defines': ['-D', 'use_concatenated_impulse_responses'], 1526 'grit_defines': ['-D', 'use_concatenated_impulse_responses'],
1527 }], 1527 }],
1528 ['clang_use_chrome_plugins==1 and OS!="win"', { 1528 ['clang_use_chrome_plugins==1 and OS!="win"', {
1529 'clang_chrome_plugins_flags': [ 1529 'variables': {
1530 '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)' 1530 'clang_chrome_plugins_flags': [
1531 '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
1532 ],
1533 },
1534 'conditions': [
1535 ['OS=="linux" and chromeos==0', {
1536 'clang_chrome_plugins_flags': [
1537 '<@(clang_chrome_plugins_flags)'
1538 ],
1539 }, {
1540 # TODO(rsleevi): http://crbug.com/115047 - This warning is only
1541 # enabled for Linux for now. Disable everywhere else.
1542 'clang_chrome_plugins_flags': [
1543 '<@(clang_chrome_plugins_flags)',
1544 '-Xclang',
1545 '-plugin-arg-find-bad-constructs',
1546 '-Xclang',
1547 'skip-virtuals-in-implementations',
1548 ],
1549 }]
1531 ], 1550 ],
1532 }], 1551 }],
1533 1552
1534 ['asan==1 and OS!="win"', { 1553 ['asan==1 and OS!="win"', {
1535 'clang%': 1, 1554 'clang%': 1,
1536 }], 1555 }],
1537 ['asan==1 and OS=="mac"', { 1556 ['asan==1 and OS=="mac"', {
1538 # See http://crbug.com/145503. 1557 # See http://crbug.com/145503.
1539 'component': "static_library", 1558 'component': "static_library",
1540 # TODO(glider): we do not strip ASan binaries until the dynamic ASan 1559 # TODO(glider): we do not strip ASan binaries until the dynamic ASan
(...skipping 2859 matching lines...) Expand 10 before | Expand all | Expand 10 after
4400 # settings in target dicts. SYMROOT is a special case, because many other 4419 # settings in target dicts. SYMROOT is a special case, because many other
4401 # Xcode variables depend on it, including variables such as 4420 # Xcode variables depend on it, including variables such as
4402 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4421 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4403 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4422 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4404 # files to appear (when present) in the UI as actual files and not red 4423 # files to appear (when present) in the UI as actual files and not red
4405 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4424 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4406 # and therefore SYMROOT, needs to be set at the project level. 4425 # and therefore SYMROOT, needs to be set at the project level.
4407 'SYMROOT': '<(DEPTH)/xcodebuild', 4426 'SYMROOT': '<(DEPTH)/xcodebuild',
4408 }, 4427 },
4409 } 4428 }
OLDNEW
« no previous file with comments | « base/debug/trace_event_impl.cc ('k') | cc/resources/tile_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698