chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

index 51a6881343ee64b3821aa353b3581caaf278aad7..6a9ac2fbbf8eb617f69f59f6abf9363b4616abe0 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

@@ -1714,7 +1714,7 @@ class BookmarkBarViewTest21 : public BookmarkBarViewEventTestBase {

protected:

// Move the mouse to the empty folder on the bookmark bar and press the

// left mouse button.

- virtual void DoTestOnMessageLoop() {

+ virtual void DoTestOnMessageLoop() OVERRIDE {

views::TextButton* button = GetBookmarkButton(5);

ui_test_utils::MoveMouseToCenterAndPress(button, ui_controls::LEFT,

ui_controls::DOWN | ui_controls::UP,