net/quic/congestion_control/inter_arrival_bitrate_ramp_up_test.cc - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/congestion_control/inter_arrival_bitrate_ramp_up_test.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/congestion_control/inter_arrival_bitrate_ramp_up_test.cc

diff --git a/net/quic/congestion_control/inter_arrival_bitrate_ramp_up_test.cc b/net/quic/congestion_control/inter_arrival_bitrate_ramp_up_test.cc

index b64430145f16be7c1ee14d76745c4a7dbc44cd54..acae78d2056c47f4c3bba1a5776f7cf6e8bbe9f8 100644

--- a/net/quic/congestion_control/inter_arrival_bitrate_ramp_up_test.cc

+++ b/net/quic/congestion_control/inter_arrival_bitrate_ramp_up_test.cc

@@ -18,7 +18,7 @@ class InterArrivalBitrateRampUpTest : public ::testing::Test {

hundred_ms_(QuicTime::Delta::FromMilliseconds(100)),

bitrate_ramp_up_(&clock_) {

}

- void SetUp() {

+ virtual void SetUp() {

clock_.AdvanceTime(one_ms_);

}

const QuicTime::Delta one_ms_;