Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/common/extensions/features/base_feature_provider.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/features/base_feature_provider.cc
diff --git a/chrome/common/extensions/features/base_feature_provider.cc b/chrome/common/extensions/features/base_feature_provider.cc
index 506e1b6e7a569758b9c7ec4b71371584d041a70f..285426d147d108f684711b6ef13a51a177ddc7e8 100644
--- a/chrome/common/extensions/features/base_feature_provider.cc
+++ b/chrome/common/extensions/features/base_feature_provider.cc
@@ -32,11 +32,11 @@ class LazyFeatureProvider : public FeatureProvider {
resource_id_(resource_id) {
}
- virtual Feature* GetFeature(const std::string& name) {
+ virtual Feature* GetFeature(const std::string& name) OVERRIDE {
return GetBaseFeatureProvider()->GetFeature(name);
}
- virtual std::set<std::string> GetAllFeatureNames() {
+ virtual std::set<std::string> GetAllFeatureNames() OVERRIDE {
return GetBaseFeatureProvider()->GetAllFeatureNames();
}

Powered by Google App Engine
This is Rietveld 408576698