content/browser/renderer_host/smooth_scroll_gesture_controller_unittest.cc - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/smooth_scroll_gesture_controller_unittest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/smooth_scroll_gesture_controller_unittest.cc

diff --git a/content/browser/renderer_host/smooth_scroll_gesture_controller_unittest.cc b/content/browser/renderer_host/smooth_scroll_gesture_controller_unittest.cc

index 0e46dc584cffbc3f5e45c4383646c36df0061260..96b70a2db21c08bc4f12288cc6defe837a5a24fc 100644

--- a/content/browser/renderer_host/smooth_scroll_gesture_controller_unittest.cc

+++ b/content/browser/renderer_host/smooth_scroll_gesture_controller_unittest.cc

@@ -91,8 +91,7 @@ class SmoothScrollGestureControllerTest : public testing::Test {

public:

SmoothScrollGestureControllerTest() : process_(NULL) {

}

- ~SmoothScrollGestureControllerTest() {

- }

+ virtual ~SmoothScrollGestureControllerTest() {}

protected:

// testing::Test implementation:

« no previous file with comments | « content/browser/loader/resource_dispatcher_host_unittest.cc ('k') | content/renderer/dom_operations_browsertest.cc » ('j') | no next file with comments »