Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/tile_manager_unittest.cc ('k') | cc/trees/layer_tree_host_unittest_animation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index 7f3cf1b4f2bdd692e8e32100a271a15c07da972f..323bd30a428e813d53361710b086ad596c15b9d2 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -2357,7 +2357,7 @@ class LayerTreeHostTestUninvertibleTransformDoesNotBlockActivation
PostSetNeedsCommitToMainThread();
}
- virtual void TreeActivatedOnThread(LayerTreeHostImpl* host_impl) {
+ virtual void TreeActivatedOnThread(LayerTreeHostImpl* host_impl) OVERRIDE {
EndTest();
}
@@ -2577,7 +2577,7 @@ class LayerTreeHostTestAsyncReadback : public LayerTreeHostTest {
PostSetNeedsCommitToMainThread();
}
- virtual void DidCommitAndDrawFrame() {
+ virtual void DidCommitAndDrawFrame() OVERRIDE {
WaitForCallback();
}
@@ -2639,7 +2639,7 @@ class LayerTreeHostTestAsyncReadback : public LayerTreeHostTest {
callbacks_.push_back(gfx::Size(bitmap->width(), bitmap->height()));
}
- virtual void AfterTest() {
+ virtual void AfterTest() OVERRIDE {
EXPECT_EQ(4u, callbacks_.size());
}
@@ -2700,7 +2700,7 @@ class LayerTreeHostTestAsyncReadbackLayerDestroyed : public LayerTreeHostTest {
PostSetNeedsCommitToMainThread();
}
- virtual void DidCommit() {
+ virtual void DidCommit() OVERRIDE {
int frame = layer_tree_host()->commit_number();
switch (frame) {
case 1:
@@ -2755,7 +2755,7 @@ class LayerTreeHostTestAsyncReadbackLayerDestroyed : public LayerTreeHostTest {
++callback_count_;
}
- virtual void AfterTest() {}
+ virtual void AfterTest() OVERRIDE {}
int callback_count_;
FakeContentLayerClient client_;
« no previous file with comments | « cc/resources/tile_manager_unittest.cc ('k') | cc/trees/layer_tree_host_unittest_animation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698