Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: chromeos/display/output_configurator_unittest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/display/output_configurator_unittest.cc
diff --git a/chromeos/display/output_configurator_unittest.cc b/chromeos/display/output_configurator_unittest.cc
index 3dec5cabc8a2df2bbd619681b4ab0ec03c94faa4..0b2ee487ed218e74e6548bb321d5733858ab8f21 100644
--- a/chromeos/display/output_configurator_unittest.cc
+++ b/chromeos/display/output_configurator_unittest.cc
@@ -155,10 +155,12 @@ class TestDelegate : public OutputConfigurator::Delegate {
virtual void CreateFrameBuffer(
int width,
int height,
- const std::vector<OutputConfigurator::CrtcConfig>& configs) {
- AppendAction(GetFramebufferAction(width, height,
- configs.size() >= 1 ? configs[0].crtc : 0,
- configs.size() >= 2 ? configs[1].crtc : 0));
+ const std::vector<OutputConfigurator::CrtcConfig>& configs) OVERRIDE {
+ AppendAction(
+ GetFramebufferAction(width,
+ height,
+ configs.size() >= 1 ? configs[0].crtc : 0,
+ configs.size() >= 2 ? configs[1].crtc : 0));
}
virtual void ConfigureCTM(
int touch_device_id,
@@ -201,7 +203,7 @@ class TestDelegate : public OutputConfigurator::Delegate {
class TestStateController : public OutputConfigurator::StateController {
public:
TestStateController() : state_(STATE_DUAL_EXTENDED) {}
- ~TestStateController() {}
+ virtual ~TestStateController() {}
void set_state(OutputState state) { state_ = state; }
« no previous file with comments | « chromeos/dbus/experimental_bluetooth_device_client.cc ('k') | chromeos/ime/component_extension_ime_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698