Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Unified Diff: webkit/fileapi/copy_or_move_file_validator_unittest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/widget_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/copy_or_move_file_validator_unittest.cc
diff --git a/webkit/fileapi/copy_or_move_file_validator_unittest.cc b/webkit/fileapi/copy_or_move_file_validator_unittest.cc
index d33ad6ade7e898acd945233da0333baa04e5cda5..505b2aa7e529900eee4e596fb7ffd76b1aafc9c2 100644
--- a/webkit/fileapi/copy_or_move_file_validator_unittest.cc
+++ b/webkit/fileapi/copy_or_move_file_validator_unittest.cc
@@ -178,7 +178,7 @@ class TestCopyOrMoveFileValidatorFactory
virtual CopyOrMoveFileValidator* CreateCopyOrMoveFileValidator(
const FileSystemURL& /*src_url*/,
- const base::FilePath& /*platform_path*/) {
+ const base::FilePath& /*platform_path*/) OVERRIDE {
return new TestCopyOrMoveFileValidator(all_valid_);
}
@@ -191,7 +191,8 @@ class TestCopyOrMoveFileValidatorFactory
}
virtual ~TestCopyOrMoveFileValidator() {}
- virtual void StartValidation(const ResultCallback& result_callback) {
+ virtual void StartValidation(
+ const ResultCallback& result_callback) OVERRIDE {
// Post the result since a real validator must do work asynchronously.
MessageLoop::current()->PostTask(FROM_HERE, base::Bind(result_callback,
result_));
« no previous file with comments | « ui/views/widget/widget_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698