Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2606)

Unified Diff: dbus/object_manager_unittest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dbus/object_manager_unittest.cc
diff --git a/dbus/object_manager_unittest.cc b/dbus/object_manager_unittest.cc
index 3033b204879bb4c2ceba00d22e72f489827fbc44..79f4d21feb4e1ada2750b0ada7d5690da54b34e5 100644
--- a/dbus/object_manager_unittest.cc
+++ b/dbus/object_manager_unittest.cc
@@ -113,15 +113,15 @@ class ObjectManagerTest
protected:
// Called when an object is added.
- void ObjectAdded(const dbus::ObjectPath& object_path,
- const std::string& interface_name) OVERRIDE {
+ virtual void ObjectAdded(const dbus::ObjectPath& object_path,
+ const std::string& interface_name) OVERRIDE {
added_objects_.push_back(std::make_pair(object_path, interface_name));
message_loop_.Quit();
}
// Called when an object is removed.
- void ObjectRemoved(const dbus::ObjectPath& object_path,
- const std::string& interface_name) OVERRIDE {
+ virtual void ObjectRemoved(const dbus::ObjectPath& object_path,
+ const std::string& interface_name) OVERRIDE {
removed_objects_.push_back(std::make_pair(object_path, interface_name));
message_loop_.Quit();
}
« no previous file with comments | « content/renderer/resource_fetcher_browsertest.cc ('k') | net/quic/congestion_control/available_channel_estimator_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698