Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: chromeos/ime/component_extension_ime_manager_unittest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/ime/component_extension_ime_manager_unittest.cc
diff --git a/chromeos/ime/component_extension_ime_manager_unittest.cc b/chromeos/ime/component_extension_ime_manager_unittest.cc
index 5de1657ace77cd9e2a014ca4c2b7d328568d3371..f921ef0150c53d64aba515cc99663f064beb0275 100644
--- a/chromeos/ime/component_extension_ime_manager_unittest.cc
+++ b/chromeos/ime/component_extension_ime_manager_unittest.cc
@@ -28,7 +28,7 @@ class ComponentExtensionIMEManagerTest :
on_initialized_callcount_(0) {
}
- void SetUp() {
+ virtual void SetUp() {
ime_list_.clear();
ComponentExtensionIME ext1;
@@ -129,7 +129,7 @@ class ComponentExtensionIMEManagerTest :
}
- void TearDown() {
+ virtual void TearDown() {
EXPECT_EQ(1, on_initialized_callcount_);
component_ext_mgr_->RemoveObserver(this);
}
@@ -140,7 +140,7 @@ class ComponentExtensionIMEManagerTest :
std::vector<ComponentExtensionIME> ime_list_;
private:
- void OnInitialized() {
+ virtual void OnInitialized() OVERRIDE {
++on_initialized_callcount_;
}
« no previous file with comments | « chromeos/display/output_configurator_unittest.cc ('k') | components/autofill/browser/autofill_data_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698