Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: ash/shell/app_list.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ash/shelf/shelf_widget.cc ('k') | ash/wm/partial_screenshot_view_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "ash/session_state_delegate.h" 7 #include "ash/session_state_delegate.h"
8 #include "ash/shell.h" 8 #include "ash/shell.h"
9 #include "ash/shell/example_factory.h" 9 #include "ash/shell/example_factory.h"
10 #include "ash/shell/toplevel_window.h" 10 #include "ash/shell/toplevel_window.h"
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 } 288 }
289 289
290 virtual void ViewActivationChanged(bool active) OVERRIDE { 290 virtual void ViewActivationChanged(bool active) OVERRIDE {
291 // Nothing needs to be done. 291 // Nothing needs to be done.
292 } 292 }
293 293
294 virtual gfx::ImageSkia GetWindowIcon() OVERRIDE { 294 virtual gfx::ImageSkia GetWindowIcon() OVERRIDE {
295 return gfx::ImageSkia(); 295 return gfx::ImageSkia();
296 } 296 }
297 297
298 virtual base::string16 GetCurrentUserName() { 298 virtual base::string16 GetCurrentUserName() OVERRIDE {
299 return base::string16(); 299 return base::string16();
300 } 300 }
301 301
302 virtual base::string16 GetCurrentUserEmail() { 302 virtual base::string16 GetCurrentUserEmail() OVERRIDE {
303 return base::string16(); 303 return base::string16();
304 } 304 }
305 305
306 virtual void OpenSettings() { 306 virtual void OpenSettings() OVERRIDE {
307 // Nothing needs to be done. 307 // Nothing needs to be done.
308 } 308 }
309 309
310 virtual void OpenFeedback() { 310 virtual void OpenFeedback() OVERRIDE {
311 // Nothing needs to be done. 311 // Nothing needs to be done.
312 } 312 }
313 313
314 app_list::AppListModel* model_; 314 app_list::AppListModel* model_;
315 315
316 DISALLOW_COPY_AND_ASSIGN(ExampleAppListViewDelegate); 316 DISALLOW_COPY_AND_ASSIGN(ExampleAppListViewDelegate);
317 }; 317 };
318 318
319 } // namespace 319 } // namespace
320 320
321 app_list::AppListViewDelegate* CreateAppListViewDelegate() { 321 app_list::AppListViewDelegate* CreateAppListViewDelegate() {
322 return new ExampleAppListViewDelegate; 322 return new ExampleAppListViewDelegate;
323 } 323 }
324 324
325 } // namespace shell 325 } // namespace shell
326 } // namespace ash 326 } // namespace ash
OLDNEW
« no previous file with comments | « ash/shelf/shelf_widget.cc ('k') | ash/wm/partial_screenshot_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698