Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/net/connectivity_state_helper.cc ('k') | chrome/browser/errorpage_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index f9a31626abbde403c90394951b7fccbb49a190b9..72a9e21e25fa56d03d38c73fbd39d7253d717797 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -138,26 +138,24 @@ class DevToolsConfirmInfoBarDelegate : public ConfirmInfoBarDelegate {
message_(message) {
}
- virtual string16 GetMessageText() const {
- return message_;
- }
+ virtual string16 GetMessageText() const OVERRIDE { return message_; }
- virtual bool Accept() {
+ virtual bool Accept() OVERRIDE {
callback_.Run(true);
callback_.Reset();
return true;
}
- virtual bool Cancel() {
+ virtual bool Cancel() OVERRIDE {
callback_.Run(false);
callback_.Reset();
return true;
}
- string16 GetButtonLabel(InfoBarButton button) const {
- return l10n_util::GetStringUTF16((button == BUTTON_OK) ?
- IDS_DEV_TOOLS_CONFIRM_ALLOW_BUTTON :
- IDS_DEV_TOOLS_CONFIRM_DENY_BUTTON);
+ virtual string16 GetButtonLabel(InfoBarButton button) const OVERRIDE {
+ return l10n_util::GetStringUTF16((button == BUTTON_OK)
+ ? IDS_DEV_TOOLS_CONFIRM_ALLOW_BUTTON
+ : IDS_DEV_TOOLS_CONFIRM_DENY_BUTTON);
}
private:
« no previous file with comments | « chrome/browser/chromeos/net/connectivity_state_helper.cc ('k') | chrome/browser/errorpage_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698