Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2633)

Unified Diff: chrome/browser/notifications/notification_browsertest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_browsertest.cc
diff --git a/chrome/browser/notifications/notification_browsertest.cc b/chrome/browser/notifications/notification_browsertest.cc
index d8a839da13e73973c16b732eaf07fc852a378149..55695c6500cf269076ad3684cb0f94bc678c62d5 100644
--- a/chrome/browser/notifications/notification_browsertest.cc
+++ b/chrome/browser/notifications/notification_browsertest.cc
@@ -102,11 +102,12 @@ class MessageCenterChangeObserver
const std::string& notification_id) OVERRIDE {
OnMessageCenterChanged();
}
- virtual void OnNotificationRemoved(
- const std::string& notification_id, bool by_user) {
+ virtual void OnNotificationRemoved(const std::string& notification_id,
+ bool by_user) OVERRIDE {
OnMessageCenterChanged();
}
- virtual void OnNotificationUpdated(const std::string& notification_id) {
+ virtual void OnNotificationUpdated(
+ const std::string& notification_id) OVERRIDE {
OnMessageCenterChanged();
}

Powered by Google App Engine
This is Rietveld 408576698