Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: chrome/browser/chromeos/cros/cert_library.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros/cert_library.cc
diff --git a/chrome/browser/chromeos/cros/cert_library.cc b/chrome/browser/chromeos/cros/cert_library.cc
index b5d7673859db797b0c93294bc7787656c5e26d75..a8c502a9a503095e65a42ef29d50a1cd438faa8f 100644
--- a/chrome/browser/chromeos/cros/cert_library.cc
+++ b/chrome/browser/chromeos/cros/cert_library.cc
@@ -448,31 +448,31 @@ class CertLibraryImplStub : public CertLibrary {
}
virtual ~CertLibraryImplStub() {}
- virtual void AddObserver(Observer* observer) {}
- virtual void RemoveObserver(Observer* observer) {}
- virtual void LoadKeyStore() {}
- virtual bool CertificatesLoading() const {
+ virtual void AddObserver(Observer* observer) OVERRIDE {}
+ virtual void RemoveObserver(Observer* observer) OVERRIDE {}
+ virtual void LoadKeyStore() OVERRIDE {}
+ virtual bool CertificatesLoading() const OVERRIDE {
return false;
}
- virtual bool CertificatesLoaded() const {
+ virtual bool CertificatesLoaded() const OVERRIDE {
return true;
}
- virtual bool IsHardwareBacked() const {
+ virtual bool IsHardwareBacked() const OVERRIDE {
return false;
}
- virtual const std::string& GetTpmTokenName() const {
+ virtual const std::string& GetTpmTokenName() const OVERRIDE {
return token_name_;
}
- virtual const CertList& GetCertificates() const {
+ virtual const CertList& GetCertificates() const OVERRIDE {
return cert_list_;
}
- virtual const CertList& GetUserCertificates() const {
+ virtual const CertList& GetUserCertificates() const OVERRIDE {
return cert_list_;
}
- virtual const CertList& GetServerCertificates() const {
+ virtual const CertList& GetServerCertificates() const OVERRIDE {
return cert_list_;
}
- virtual const CertList& GetCACertificates() const {
+ virtual const CertList& GetCACertificates() const OVERRIDE {
return cert_list_;
}
« no previous file with comments | « chrome/browser/chrome_security_exploit_browsertest.cc ('k') | chrome/browser/chromeos/net/connectivity_state_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698