net/tools/quic/quic_time_wait_list_manager.cc - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_time_wait_list_manager.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/quic/quic_time_wait_list_manager.cc

diff --git a/net/tools/quic/quic_time_wait_list_manager.cc b/net/tools/quic/quic_time_wait_list_manager.cc

index 0bf44a81b15bc594db0349009993730b846d542e..81e199ba2ab9f74944d2f0e799251808955f007e 100644

--- a/net/tools/quic/quic_time_wait_list_manager.cc

+++ b/net/tools/quic/quic_time_wait_list_manager.cc

@@ -37,7 +37,7 @@ class GuidCleanUpAlarm : public EpollAlarm {

: time_wait_list_manager_(time_wait_list_manager) {

}

- virtual int64 OnAlarm() {

+ virtual int64 OnAlarm() OVERRIDE {

EpollAlarm::OnAlarm();

time_wait_list_manager_->CleanUpOldGuids();

// Let the time wait manager register the alarm at appropriate time.

« no previous file with comments | « net/tools/quic/quic_in_memory_cache.cc ('k') | sync/syncable/parent_child_index_unittest.cc » ('j') | no next file with comments »