net/tools/quic/end_to_end_test.cc - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/quic/end_to_end_test.cc

diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc

index 896b0f816867148d00fff8dc7e7993eda532cbf2..12e2da983fbb9c856b3d44ac56b1f73fae8840af 100644

--- a/net/tools/quic/end_to_end_test.cc

+++ b/net/tools/quic/end_to_end_test.cc

@@ -66,7 +66,7 @@ class ServerThread : public base::SimpleThread {

virtual ~ServerThread() {

}

- virtual void Run() {

+ virtual void Run() OVERRIDE {

server_.Listen(address_);

port_lock_.Acquire();

« no previous file with comments | « net/quic/test_tools/crypto_test_utils.cc ('k') | net/tools/quic/quic_dispatcher.cc » ('j') | no next file with comments »