ui/views/corewm/focus_controller_unittest.cc - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/corewm/focus_controller_unittest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/corewm/focus_controller_unittest.cc

diff --git a/ui/views/corewm/focus_controller_unittest.cc b/ui/views/corewm/focus_controller_unittest.cc

index 2d77103c8a62910617141bb59f373a2bb97e2215..62062f875c496e32e77d28ed2954f50fa2711bc6 100644

--- a/ui/views/corewm/focus_controller_unittest.cc

+++ b/ui/views/corewm/focus_controller_unittest.cc

@@ -547,7 +547,7 @@ class FocusControllerDirectTestBase : public FocusControllerTestBase {

ActivateWindowById(1);

EXPECT_EQ(1, GetFocusedWindowId());

}

- virtual void ShiftFocusOnActivationDueToHide() {

+ virtual void ShiftFocusOnActivationDueToHide() OVERRIDE {

// Similar to ShiftFocusOnActivation except the activation change is

// triggered by hiding the active window.

ActivateWindowById(1);