Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Side by Side Diff: chrome/browser/extensions/api/audio/audio_service.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/audio/audio_service.h" 5 #include "chrome/browser/extensions/api/audio/audio_service.h"
6 6
7 namespace extensions { 7 namespace extensions {
8 8
9 class AudioServiceImpl : public AudioService { 9 class AudioServiceImpl : public AudioService {
10 public: 10 public:
11 AudioServiceImpl() {} 11 AudioServiceImpl() {}
12 virtual ~AudioServiceImpl() {} 12 virtual ~AudioServiceImpl() {}
13 13
14 // Called by listeners to this service to add/remove themselves as observers. 14 // Called by listeners to this service to add/remove themselves as observers.
15 virtual void AddObserver(Observer* observer); 15 virtual void AddObserver(Observer* observer) OVERRIDE;
16 virtual void RemoveObserver(Observer* observer); 16 virtual void RemoveObserver(Observer* observer) OVERRIDE;
17 17
18 // Start to query audio device information. 18 // Start to query audio device information.
19 virtual void StartGetInfo(const GetInfoCallback& callback); 19 virtual void StartGetInfo(const GetInfoCallback& callback) OVERRIDE;
20 }; 20 };
21 21
22 void AudioServiceImpl::AddObserver(Observer* observer) { 22 void AudioServiceImpl::AddObserver(Observer* observer) {
23 // TODO: implement this for platforms other than Chrome OS. 23 // TODO: implement this for platforms other than Chrome OS.
24 } 24 }
25 25
26 void AudioServiceImpl::RemoveObserver(Observer* observer) { 26 void AudioServiceImpl::RemoveObserver(Observer* observer) {
27 // TODO: implement this for platforms other than Chrome OS. 27 // TODO: implement this for platforms other than Chrome OS.
28 } 28 }
29 29
30 AudioService* AudioService::CreateInstance() { 30 AudioService* AudioService::CreateInstance() {
31 return new AudioServiceImpl; 31 return new AudioServiceImpl;
32 } 32 }
33 33
34 void AudioServiceImpl::StartGetInfo(const GetInfoCallback& callback) { 34 void AudioServiceImpl::StartGetInfo(const GetInfoCallback& callback) {
35 // TODO: implement this for platforms other than Chrome OS. 35 // TODO: implement this for platforms other than Chrome OS.
36 if (!callback.is_null()) 36 if (!callback.is_null())
37 callback.Run(OutputInfo(), InputInfo(), false); 37 callback.Run(OutputInfo(), InputInfo(), false);
38 } 38 }
39 39
40 } // namespace extensions 40 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/errorpage_browsertest.cc ('k') | chrome/browser/extensions/extension_crash_recovery_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698