chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/signin/oauth2_token_service_unittest.cc ('k') | chrome/browser/ui/global_error/global_error_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

diff --git a/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc b/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

index 54863bcf665241b1d69750650d104e077f60ec91..b318509255bb7b58f7a3892de6e1b9b17e6d5b74 100644

--- a/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

+++ b/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

@@ -69,7 +69,7 @@ class LauncherFaviconLoaderBrowsertest

virtual ~LauncherFaviconLoaderBrowsertest() {

}

- virtual void SetUpOnMainThread() {

+ virtual void SetUpOnMainThread() OVERRIDE {

WebContents* web_contents =

browser()->tab_strip_model()->GetActiveWebContents();

contents_observer_.reset(new ContentsObserver(web_contents));