chrome/browser/chrome_security_exploit_browsertest.cc - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_security_exploit_browsertest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_security_exploit_browsertest.cc

diff --git a/chrome/browser/chrome_security_exploit_browsertest.cc b/chrome/browser/chrome_security_exploit_browsertest.cc

index fd9bdc5c745db1af9c6084c3a2c4f0f42f602e0d..2ac5cdc116ffc431b796f1aebf5a0bd32f3c7e05 100644

--- a/chrome/browser/chrome_security_exploit_browsertest.cc

+++ b/chrome/browser/chrome_security_exploit_browsertest.cc

@@ -30,7 +30,7 @@ class ChromeSecurityExploitBrowserTest : public InProcessBrowserTest {

ChromeSecurityExploitBrowserTest() {}

virtual ~ChromeSecurityExploitBrowserTest() {}

- virtual void SetUpCommandLine(CommandLine* command_line) {

+ virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {

ASSERT_TRUE(test_server()->Start());

net::TestServer https_server(

net::TestServer::TYPE_HTTPS,