tools/clang/scripts/plugin_flags.sh - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/scripts/plugin_flags.sh

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 #!/bin/bash	1 #!/bin/bash

2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 # This script returns the flags that should be used when GYP_DEFINES contains	6 # This script returns the flags that should be used when GYP_DEFINES contains

7 # clang_use_chrome_plugins. The flags are stored in a script so that they can	7 # clang_use_chrome_plugins. The flags are stored in a script so that they can

8 # be changed on the bots without requiring a master restart.	8 # be changed on the bots without requiring a master restart.

9	9

10 THIS_ABS_DIR=$(cd $(dirname $0) && echo $PWD)	10 THIS_ABS_DIR=$(cd $(dirname $0) && echo $PWD)

11 CLANG_LIB_PATH=$THIS_ABS_DIR/../../../third_party/llvm-build/Release+Asserts/lib	11 CLANG_LIB_PATH=$THIS_ABS_DIR/../../../third_party/llvm-build/Release+Asserts/lib

12	12

13 if uname -s \| grep -q Darwin; then	13 if uname -s \| grep -q Darwin; then

14 LIBSUFFIX=dylib	14 LIBSUFFIX=dylib

15 else	15 else

16 LIBSUFFIX=so	16 LIBSUFFIX=so

17 fi	17 fi

18	18

19 echo -Xclang -load -Xclang $CLANG_LIB_PATH/libFindBadConstructs.$LIBSUFFIX \	19 echo -Xclang -load -Xclang $CLANG_LIB_PATH/libFindBadConstructs.$LIBSUFFIX \

20 -Xclang -add-plugin -Xclang find-bad-constructs \	20 -Xclang -add-plugin -Xclang find-bad-constructs

21 -Xclang -plugin-arg-find-bad-constructs \

22 -Xclang skip-virtuals-in-implementations

OLD	NEW

« no previous file with comments | « sync/syncable/parent_child_index_unittest.cc ('k') | ui/app_list/views/app_list_menu_views.cc » ('j') | no next file with comments »