tools/clang/scripts/plugin_flags.sh - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/scripts/plugin_flags.sh

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/scripts/plugin_flags.sh

diff --git a/tools/clang/scripts/plugin_flags.sh b/tools/clang/scripts/plugin_flags.sh

index 92eaad9626b059f37750177f8faa67d3195ba642..0d8dea566bfd23f59ba6e436d98bfd9da5e97c45 100755

--- a/tools/clang/scripts/plugin_flags.sh

+++ b/tools/clang/scripts/plugin_flags.sh

@@ -17,6 +17,4 @@ else

echo -Xclang -load -Xclang $CLANG_LIB_PATH/libFindBadConstructs.$LIBSUFFIX \

- -Xclang -add-plugin -Xclang find-bad-constructs \

- -Xclang -plugin-arg-find-bad-constructs \

- -Xclang skip-virtuals-in-implementations

+ -Xclang -add-plugin -Xclang find-bad-constructs