Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Side by Side Diff: chrome/browser/signin/oauth2_token_service_unittest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/stringprintf.h" 7 #include "base/stringprintf.h"
8 #include "chrome/browser/signin/oauth2_token_service.h" 8 #include "chrome/browser/signin/oauth2_token_service.h"
9 #include "chrome/browser/signin/oauth2_token_service_test_util.h" 9 #include "chrome/browser/signin/oauth2_token_service_test_util.h"
10 #include "chrome/browser/signin/token_service_factory.h" 10 #include "chrome/browser/signin/token_service_factory.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 explicit TestOAuth2TokenService(net::URLRequestContextGetter* getter) 47 explicit TestOAuth2TokenService(net::URLRequestContextGetter* getter)
48 : OAuth2TokenService(getter) { 48 : OAuth2TokenService(getter) {
49 } 49 }
50 50
51 // For testing: set the refresh token to be used. 51 // For testing: set the refresh token to be used.
52 void set_refresh_token(const std::string& refresh_token) { 52 void set_refresh_token(const std::string& refresh_token) {
53 refresh_token_ = refresh_token; 53 refresh_token_ = refresh_token;
54 } 54 }
55 55
56 protected: 56 protected:
57 std::string GetRefreshToken() OVERRIDE { 57 virtual std::string GetRefreshToken() OVERRIDE { return refresh_token_; }
58 return refresh_token_;
59 }
60 58
61 private: 59 private:
62 std::string refresh_token_; 60 std::string refresh_token_;
63 }; 61 };
64 62
65 class OAuth2TokenServiceTest : public TokenServiceTestHarness { 63 class OAuth2TokenServiceTest : public TokenServiceTestHarness {
66 public: 64 public:
67 OAuth2TokenServiceTest() 65 OAuth2TokenServiceTest()
68 : request_context_getter_(new net::TestURLRequestContextGetter( 66 : request_context_getter_(new net::TestURLRequestContextGetter(
69 message_loop_.message_loop_proxy())) { 67 message_loop_.message_loop_proxy())) {
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 EXPECT_EQ(1, consumer.number_of_errors_); 412 EXPECT_EQ(1, consumer.number_of_errors_);
415 413
416 fetcher = factory_.GetFetcherByID(0); 414 fetcher = factory_.GetFetcherByID(0);
417 EXPECT_TRUE(fetcher); 415 EXPECT_TRUE(fetcher);
418 fetcher->set_response_code(net::HTTP_UNAUTHORIZED); 416 fetcher->set_response_code(net::HTTP_UNAUTHORIZED);
419 fetcher->SetResponseString(std::string()); 417 fetcher->SetResponseString(std::string());
420 fetcher->delegate()->OnURLFetchComplete(fetcher); 418 fetcher->delegate()->OnURLFetchComplete(fetcher);
421 EXPECT_EQ(0, consumer.number_of_successful_tokens_); 419 EXPECT_EQ(0, consumer.number_of_successful_tokens_);
422 EXPECT_EQ(2, consumer.number_of_errors_); 420 EXPECT_EQ(2, consumer.number_of_errors_);
423 } 421 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698