Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: ui/gfx/image/image.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/app_list/views/app_list_menu_views.cc ('k') | ui/message_center/views/message_center_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/image/image.cc
diff --git a/ui/gfx/image/image.cc b/ui/gfx/image/image.cc
index b076942de24c5f85ecee6e5e58af11b6404c2641..252a154cdb4321616e5fbcfed10beda53dfd1823 100644
--- a/ui/gfx/image/image.cc
+++ b/ui/gfx/image/image.cc
@@ -342,15 +342,15 @@ class ImageRepGdk : public ImageRep {
}
}
- virtual int Width() const {
+ virtual int Width() const OVERRIDE {
return gdk_pixbuf_get_width(pixbuf_);
}
- virtual int Height() const {
+ virtual int Height() const OVERRIDE {
return gdk_pixbuf_get_height(pixbuf_);
}
- virtual gfx::Size Size() const {
+ virtual gfx::Size Size() const OVERRIDE {
return gfx::Size(Width(), Height());
}
@@ -376,15 +376,15 @@ class ImageRepCairo : public ImageRep {
delete cairo_cache_;
}
- virtual int Width() const {
+ virtual int Width() const OVERRIDE {
return cairo_cache_->Width();
}
- virtual int Height() const {
+ virtual int Height() const OVERRIDE {
return cairo_cache_->Height();
}
- virtual gfx::Size Size() const {
+ virtual gfx::Size Size() const OVERRIDE {
return gfx::Size(Width(), Height());
}
« no previous file with comments | « ui/app_list/views/app_list_menu_views.cc ('k') | ui/message_center/views/message_center_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698