ui/app_list/views/app_list_menu_views.cc - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/app_list_menu_views.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/app_list/views/app_list_menu_views.cc

diff --git a/ui/app_list/views/app_list_menu_views.cc b/ui/app_list/views/app_list_menu_views.cc

index 72437568410087464046fa4a57038c04f91a1cba..1d8a4e402aac053b2d9d81f8baa29cc0b182366e 100644

--- a/ui/app_list/views/app_list_menu_views.cc

+++ b/ui/app_list/views/app_list_menu_views.cc

@@ -94,9 +94,9 @@ class AppListMenuModelAdapter : public views::MenuModelAdapter {

virtual ~AppListMenuModelAdapter() {}

// Overridden from views::MenuModelAdapter:

- MenuItemView* AppendMenuItem(MenuItemView* menu,

- ui::MenuModel* model,

- int index) OVERRIDE {

+ virtual MenuItemView* AppendMenuItem(MenuItemView* menu,

+ ui::MenuModel* model,

+ int index) OVERRIDE {

if (!delegate_)

return NULL;

« no previous file with comments | « tools/clang/scripts/plugin_flags.sh ('k') | ui/gfx/image/image.cc » ('j') | no next file with comments »