Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2708)

Unified Diff: ash/launcher/launcher_button.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/shelf/shelf_widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/launcher/launcher_button.cc
diff --git a/ash/launcher/launcher_button.cc b/ash/launcher/launcher_button.cc
index dad5d18cedf127215197508ed084deccee9d0a9c..78fc815784842909526cd95331ebe9bc74ef1397 100644
--- a/ash/launcher/launcher_button.cc
+++ b/ash/launcher/launcher_button.cc
@@ -96,7 +96,7 @@ class LauncherButtonAnimation : public ui::AnimationDelegate {
}
// ui::AnimationDelegate
- void AnimationProgressed(const ui::Animation* animation) {
+ virtual void AnimationProgressed(const ui::Animation* animation) OVERRIDE {
if (animation != &animation_)
return;
if (!animation_.is_animating())
@@ -126,7 +126,7 @@ class LauncherButton::BarView : public views::ImageView,
show_attention_(false) {
}
- ~BarView() {
+ virtual ~BarView() {
if (show_attention_)
LauncherButtonAnimation::GetInstance()->RemoveObserver(this);
}
« no previous file with comments | « no previous file | ash/shelf/shelf_widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698