Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: net/tools/quic/quic_epoll_connection_helper.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_dispatcher_test.cc ('k') | net/tools/quic/quic_epoll_connection_helper_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_epoll_connection_helper.cc
diff --git a/net/tools/quic/quic_epoll_connection_helper.cc b/net/tools/quic/quic_epoll_connection_helper.cc
index d4266a2bd5a1ab482f93a7210448f0b976a8afc4..ba720875e6fa41b32b68b232c26f0f6506c9b932 100644
--- a/net/tools/quic/quic_epoll_connection_helper.cc
+++ b/net/tools/quic/quic_epoll_connection_helper.cc
@@ -26,7 +26,7 @@ class RetransmissionAlarm : public EpollAlarm {
: connection_(connection) {
}
- virtual int64 OnAlarm() {
+ virtual int64 OnAlarm() OVERRIDE {
EpollAlarm::OnAlarm();
// This is safe because this code is Google3 specific, and the
// Google3 QuicTime's epoch is the unix epoch.
@@ -46,7 +46,7 @@ class SendAlarm : public EpollAlarm {
: connection_(connection) {
}
- virtual int64 OnAlarm() {
+ virtual int64 OnAlarm() OVERRIDE {
EpollAlarm::OnAlarm();
connection_->OnCanWrite();
// Never reschedule the alarm, since OnCanWrite does that.
@@ -64,7 +64,7 @@ class TimeoutAlarm : public EpollAlarm {
: connection_(connection) {
}
- virtual int64 OnAlarm() {
+ virtual int64 OnAlarm() OVERRIDE {
EpollAlarm::OnAlarm();
connection_->CheckForTimeout();
// Never reschedule the alarm, since CheckForTimeout does that.
@@ -82,7 +82,7 @@ class AckAlarm : public EpollAlarm {
: connection_(connection) {
}
- virtual int64 OnAlarm() {
+ virtual int64 OnAlarm() OVERRIDE {
EpollAlarm::OnAlarm();
connection_->SendAck();
return 0;
« no previous file with comments | « net/tools/quic/quic_dispatcher_test.cc ('k') | net/tools/quic/quic_epoll_connection_helper_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698