Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: chrome/browser/chromeos/net/connectivity_state_helper.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/net/connectivity_state_helper.h" 5 #include "chrome/browser/chromeos/net/connectivity_state_helper.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/browser/chromeos/cros/cros_library.h" 8 #include "chrome/browser/chromeos/cros/cros_library.h"
9 #include "chrome/browser/chromeos/cros/network_library.h" 9 #include "chrome/browser/chromeos/cros/network_library.h"
10 #include "chromeos/chromeos_switches.h" 10 #include "chromeos/chromeos_switches.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 virtual bool IsConnected() OVERRIDE; 58 virtual bool IsConnected() OVERRIDE;
59 virtual bool IsConnecting() OVERRIDE; 59 virtual bool IsConnecting() OVERRIDE;
60 virtual bool IsConnectedType(const std::string& type) OVERRIDE; 60 virtual bool IsConnectedType(const std::string& type) OVERRIDE;
61 virtual bool IsConnectingType(const std::string& type) OVERRIDE; 61 virtual bool IsConnectingType(const std::string& type) OVERRIDE;
62 virtual std::string NetworkNameForType(const std::string& type) OVERRIDE; 62 virtual std::string NetworkNameForType(const std::string& type) OVERRIDE;
63 virtual std::string DefaultNetworkName() OVERRIDE; 63 virtual std::string DefaultNetworkName() OVERRIDE;
64 virtual bool DefaultNetworkOnline() OVERRIDE; 64 virtual bool DefaultNetworkOnline() OVERRIDE;
65 virtual void RequestScan() const OVERRIDE; 65 virtual void RequestScan() const OVERRIDE;
66 66
67 // NetworkLibrary::NetworkManagerObserver overrides. 67 // NetworkLibrary::NetworkManagerObserver overrides.
68 virtual void OnNetworkManagerChanged(NetworkLibrary* network_library); 68 virtual void OnNetworkManagerChanged(
69 NetworkLibrary* network_library) OVERRIDE;
69 70
70 private: 71 private:
71 NetworkLibrary* network_library_; 72 NetworkLibrary* network_library_;
72 }; 73 };
73 74
74 ConnectivityStateHelper::ConnectivityStateHelper() { 75 ConnectivityStateHelper::ConnectivityStateHelper() {
75 } 76 }
76 77
77 ConnectivityStateHelper::~ConnectivityStateHelper() { 78 ConnectivityStateHelper::~ConnectivityStateHelper() {
78 } 79 }
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 network_library_->RequestNetworkScan(); 279 network_library_->RequestNetworkScan();
279 } 280 }
280 281
281 void ConnectivityStateHelperNetworkLibrary::OnNetworkManagerChanged( 282 void ConnectivityStateHelperNetworkLibrary::OnNetworkManagerChanged(
282 NetworkLibrary* network_library) { 283 NetworkLibrary* network_library) {
283 FOR_EACH_OBSERVER(ConnectivityStateHelperObserver, connectivity_observers_, 284 FOR_EACH_OBSERVER(ConnectivityStateHelperObserver, connectivity_observers_,
284 NetworkManagerChanged()); 285 NetworkManagerChanged());
285 } 286 }
286 287
287 } // namespace chromeos 288 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/cros/cert_library.cc ('k') | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698