Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: net/tools/quic/quic_dispatcher_test.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_dispatcher.cc ('k') | net/tools/quic/quic_epoll_connection_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher_test.cc
diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc
index ba77cbd20b85bc63445d41bc93580b4a55dccc7c..809ddd3b050e76e57462e1c5c2cc892bfb5e28eb 100644
--- a/net/tools/quic/quic_dispatcher_test.cc
+++ b/net/tools/quic/quic_dispatcher_test.cc
@@ -109,8 +109,7 @@ class QuicDispatcherTest : public ::testing::Test {
session2_(NULL) {
}
- ~QuicDispatcherTest() {
- }
+ virtual ~QuicDispatcherTest() {}
MockConnection* connection1() {
return reinterpret_cast<MockConnection*>(session1_->connection());
@@ -238,7 +237,7 @@ TEST_F(QuicDispatcherTest, TimeWaitListManager) {
class WriteBlockedListTest : public QuicDispatcherTest {
public:
- void SetUp() {
+ virtual void SetUp() {
IPEndPoint addr(Loopback4(), 1);
EXPECT_CALL(dispatcher_, CreateQuicSession(_, addr, _, &eps_))
« no previous file with comments | « net/tools/quic/quic_dispatcher.cc ('k') | net/tools/quic/quic_epoll_connection_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698