Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7451)

Unified Diff: components/autofill/browser/autofill_data_model_unittest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/autofill_data_model_unittest.cc
diff --git a/components/autofill/browser/autofill_data_model_unittest.cc b/components/autofill/browser/autofill_data_model_unittest.cc
index 77a83856ef327b9e6894d7bd6104832e2d1d13e2..bcd8ae1684164ecc971c9e5967f253fb22ada0b3 100644
--- a/components/autofill/browser/autofill_data_model_unittest.cc
+++ b/components/autofill/browser/autofill_data_model_unittest.cc
@@ -4,6 +4,7 @@
#include "components/autofill/browser/autofill_data_model.h"
+#include "base/compiler_specific.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace autofill {
@@ -18,16 +19,17 @@ class TestAutofillDataModel : public AutofillDataModel {
virtual ~TestAutofillDataModel() {}
private:
- virtual base::string16 GetRawInfo(AutofillFieldType type) const {
+ virtual base::string16 GetRawInfo(AutofillFieldType type) const OVERRIDE {
return base::string16();
}
virtual void SetRawInfo(AutofillFieldType type,
- const base::string16& value) {}
- virtual void GetSupportedTypes(FieldTypeSet* supported_types) const {}
+ const base::string16& value) OVERRIDE {}
+ virtual void GetSupportedTypes(
+ FieldTypeSet* supported_types) const OVERRIDE {}
virtual void FillFormField(const AutofillField& field,
size_t variant,
const std::string& app_locale,
- FormFieldData* field_data) const {}
+ FormFieldData* field_data) const OVERRIDE {}
DISALLOW_COPY_AND_ASSIGN(TestAutofillDataModel);
};
« no previous file with comments | « chromeos/ime/component_extension_ime_manager_unittest.cc ('k') | content/browser/loader/resource_dispatcher_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698