Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: net/tools/quic/quic_in_memory_cache.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_epoll_connection_helper_test.cc ('k') | net/tools/quic/quic_time_wait_list_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_in_memory_cache.cc
diff --git a/net/tools/quic/quic_in_memory_cache.cc b/net/tools/quic/quic_in_memory_cache.cc
index 32ea702016a0d827cfe6057477faa0d84e413325..9d086e2768f6b873b26dca0a75b89a5a7dce6fe8 100644
--- a/net/tools/quic/quic_in_memory_cache.cc
+++ b/net/tools/quic/quic_in_memory_cache.cc
@@ -26,37 +26,45 @@ namespace {
class CachingBalsaVisitor : public BalsaVisitorInterface {
public:
CachingBalsaVisitor() : done_framing_(false) {}
- virtual void ProcessBodyData(const char* input, size_t size) {
+ virtual void ProcessBodyData(const char* input, size_t size) OVERRIDE {
AppendToBody(input, size);
}
virtual void ProcessTrailers(const BalsaHeaders& trailer) {
LOG(DFATAL) << "Trailers not supported.";
}
- virtual void MessageDone() {
+ virtual void MessageDone() OVERRIDE {
done_framing_ = true;
}
- virtual void HandleHeaderError(BalsaFrame* framer) { UnhandledError(); }
- virtual void HandleHeaderWarning(BalsaFrame* framer) { UnhandledError(); }
+ virtual void HandleHeaderError(BalsaFrame* framer) OVERRIDE {
+ UnhandledError();
+ }
+ virtual void HandleHeaderWarning(BalsaFrame* framer) OVERRIDE {
+ UnhandledError();
+ }
virtual void HandleTrailerError(BalsaFrame* framer) { UnhandledError(); }
virtual void HandleTrailerWarning(BalsaFrame* framer) { UnhandledError(); }
- virtual void HandleChunkingError(BalsaFrame* framer) { UnhandledError(); }
- virtual void HandleBodyError(BalsaFrame* framer) { UnhandledError(); }
+ virtual void HandleChunkingError(BalsaFrame* framer) OVERRIDE {
+ UnhandledError();
+ }
+ virtual void HandleBodyError(BalsaFrame* framer) OVERRIDE {
+ UnhandledError();
+ }
void UnhandledError() {
LOG(DFATAL) << "Unhandled error framing HTTP.";
}
- virtual void ProcessBodyInput(const char*, size_t) {}
- virtual void ProcessHeaderInput(const char*, size_t) {}
- virtual void ProcessTrailerInput(const char*, size_t) {}
- virtual void ProcessHeaders(const net::BalsaHeaders&) {}
+ virtual void ProcessBodyInput(const char*, size_t) OVERRIDE {}
+ virtual void ProcessHeaderInput(const char*, size_t) OVERRIDE {}
+ virtual void ProcessTrailerInput(const char*, size_t) OVERRIDE {}
+ virtual void ProcessHeaders(const net::BalsaHeaders&) OVERRIDE {}
virtual void ProcessRequestFirstLine(
const char*, size_t, const char*, size_t,
- const char*, size_t, const char*, size_t) {}
+ const char*, size_t, const char*, size_t) OVERRIDE {}
virtual void ProcessResponseFirstLine(
const char*, size_t, const char*,
- size_t, const char*, size_t, const char*, size_t) {}
- virtual void ProcessChunkLength(size_t) {}
- virtual void ProcessChunkExtensions(const char*, size_t) {}
- virtual void HeaderDone() {}
+ size_t, const char*, size_t, const char*, size_t) OVERRIDE {}
+ virtual void ProcessChunkLength(size_t) OVERRIDE {}
+ virtual void ProcessChunkExtensions(const char*, size_t) OVERRIDE {}
+ virtual void HeaderDone() OVERRIDE {}
void AppendToBody(const char* input, size_t size) {
body_.append(input, size);
« no previous file with comments | « net/tools/quic/quic_epoll_connection_helper_test.cc ('k') | net/tools/quic/quic_time_wait_list_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698