Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: net/tools/quic/quic_epoll_connection_helper_test.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_epoll_connection_helper.cc ('k') | net/tools/quic/quic_in_memory_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_epoll_connection_helper_test.cc
diff --git a/net/tools/quic/quic_epoll_connection_helper_test.cc b/net/tools/quic/quic_epoll_connection_helper_test.cc
index e4c49bae10e587781692f4f2b70b24fbe845bbb6..daaa59e0c3ec716846cbac6830108ffe9a3d8941 100644
--- a/net/tools/quic/quic_epoll_connection_helper_test.cc
+++ b/net/tools/quic/quic_epoll_connection_helper_test.cc
@@ -33,12 +33,12 @@ const bool kHasData = true;
class TestConnectionHelper : public QuicEpollConnectionHelper {
public:
- TestConnectionHelper(int fd, EpollServer* eps)
- : QuicEpollConnectionHelper(fd, eps) {
- }
+ TestConnectionHelper(int fd, EpollServer* eps)
+ : QuicEpollConnectionHelper(fd, eps) {
+ }
virtual int WritePacketToWire(const QuicEncryptedPacket& packet,
- int* error) {
+ int* error) OVERRIDE {
QuicFramer framer(kQuicVersion1,
QuicDecrypter::Create(kNULL),
QuicEncrypter::Create(kNULL),
« no previous file with comments | « net/tools/quic/quic_epoll_connection_helper.cc ('k') | net/tools/quic/quic_in_memory_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698