Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: content/renderer/resource_fetcher_browsertest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/renderer/dom_serializer_browsertest.cc ('k') | dbus/object_manager_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/glue/resource_fetcher.h" 5 #include "webkit/glue/resource_fetcher.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 fetcher_.reset(); 114 fetcher_.reset();
115 FetcherDelegate::OnURLFetchComplete(response, data); 115 FetcherDelegate::OnURLFetchComplete(response, data);
116 } 116 }
117 117
118 private: 118 private:
119 scoped_ptr<ResourceFetcher> fetcher_; 119 scoped_ptr<ResourceFetcher> fetcher_;
120 }; 120 };
121 121
122 class ResourceFetcherTests : public ContentBrowserTest { 122 class ResourceFetcherTests : public ContentBrowserTest {
123 public: 123 public:
124 virtual void SetUpCommandLine(CommandLine* command_line) { 124 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
125 command_line->AppendSwitch(switches::kSingleProcess); 125 command_line->AppendSwitch(switches::kSingleProcess);
126 #if defined(OS_WIN) && defined(USE_AURA) 126 #if defined(OS_WIN) && defined(USE_AURA)
127 // Don't want to try to create a GPU process. 127 // Don't want to try to create a GPU process.
128 command_line->AppendSwitch(switches::kDisableAcceleratedCompositing); 128 command_line->AppendSwitch(switches::kDisableAcceleratedCompositing);
129 #endif 129 #endif
130 } 130 }
131 131
132 RenderView* GetRenderView() { 132 RenderView* GetRenderView() {
133 // We could have the test on the UI thread get the WebContent's routing ID, 133 // We could have the test on the UI thread get the WebContent's routing ID,
134 // but we know this will be the first RV so skip that and just hardcode it. 134 // but we know this will be the first RV so skip that and just hardcode it.
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 ASSERT_TRUE(test_server()->Start()); 275 ASSERT_TRUE(test_server()->Start());
276 GURL url(test_server()->GetURL("slow?1")); 276 GURL url(test_server()->GetURL("slow?1"));
277 277
278 PostTaskToInProcessRendererAndWait( 278 PostTaskToInProcessRendererAndWait(
279 base::Bind( 279 base::Bind(
280 &ResourceFetcherTests::ResourceFetcherDeletedInCallbackOnRenderer, 280 &ResourceFetcherTests::ResourceFetcherDeletedInCallbackOnRenderer,
281 base::Unretained(this), url)); 281 base::Unretained(this), url));
282 } 282 }
283 283
284 } // namespace content 284 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/dom_serializer_browsertest.cc ('k') | dbus/object_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698