cc/trees/layer_tree_host_unittest_animation.cc - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_unittest_animation.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host_unittest_animation.cc

diff --git a/cc/trees/layer_tree_host_unittest_animation.cc b/cc/trees/layer_tree_host_unittest_animation.cc

index 89be84f2f605a9c95177de538d21a3946d345ac7..a86253b559234c51bc9283d102250bf4506ba13a 100644

--- a/cc/trees/layer_tree_host_unittest_animation.cc

+++ b/cc/trees/layer_tree_host_unittest_animation.cc

@@ -708,7 +708,7 @@ class LayerTreeHostAnimationTestCheckerboardDoesntStartAnimations

virtual bool PrepareToDrawOnThread(LayerTreeHostImpl* host_impl,

LayerTreeHostImpl::FrameData* frame_data,

- bool result) {

+ bool result) OVERRIDE {

if (added_animations_ < 2)

return result;

// Act like there is checkerboard when the second animation wants to draw.

« no previous file with comments | « cc/trees/layer_tree_host_unittest.cc ('k') | cc/trees/layer_tree_host_unittest_context.cc » ('j') | no next file with comments »