cc/trees/layer_tree_host_unittest_context.cc - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_unittest_context.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host_unittest_context.cc

diff --git a/cc/trees/layer_tree_host_unittest_context.cc b/cc/trees/layer_tree_host_unittest_context.cc

index 1658deafc96e20d94b69c29a07fdc18a87cf5d3b..1c3da6120382c940a80e1fc96f01d9b3640fb761 100644

--- a/cc/trees/layer_tree_host_unittest_context.cc

+++ b/cc/trees/layer_tree_host_unittest_context.cc

@@ -1374,7 +1374,7 @@ class LayerTreeHostTestCannotCreateIfCannotCreateOutputSurface

: FakeLayerTreeHostClient(FakeLayerTreeHostClient::DIRECT_3D) {}

// FakeLayerTreeHostClient

- virtual scoped_ptr<OutputSurface> CreateOutputSurface() {

+ virtual scoped_ptr<OutputSurface> CreateOutputSurface() OVERRIDE {

return scoped_ptr<OutputSurface>();

}