Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: chromeos/dbus/experimental_bluetooth_device_client.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/experimental_bluetooth_device_client.cc
diff --git a/chromeos/dbus/experimental_bluetooth_device_client.cc b/chromeos/dbus/experimental_bluetooth_device_client.cc
index 9de3c940e9f3d66eae2d9058779921525f5f8263..7cfc88f7089b5049bc60249316428dd0570945d3 100644
--- a/chromeos/dbus/experimental_bluetooth_device_client.cc
+++ b/chromeos/dbus/experimental_bluetooth_device_client.cc
@@ -86,9 +86,10 @@ class ExperimentalBluetoothDeviceClientImpl
virtual dbus::PropertySet* CreateProperties(
dbus::ObjectProxy* object_proxy,
const dbus::ObjectPath& object_path,
- const std::string& interface_name) {
+ const std::string& interface_name) OVERRIDE {
Properties* properties = new Properties(
- object_proxy, interface_name,
+ object_proxy,
+ interface_name,
base::Bind(&ExperimentalBluetoothDeviceClientImpl::OnPropertyChanged,
weak_ptr_factory_.GetWeakPtr(),
object_path));
@@ -278,17 +279,19 @@ class ExperimentalBluetoothDeviceClientImpl
private:
// Called by dbus::ObjectManager when an object with the device interface
// is created. Informs observers.
- void ObjectAdded(const dbus::ObjectPath& object_path,
- const std::string& interface_name) OVERRIDE {
- FOR_EACH_OBSERVER(ExperimentalBluetoothDeviceClient::Observer, observers_,
+ virtual void ObjectAdded(const dbus::ObjectPath& object_path,
+ const std::string& interface_name) OVERRIDE {
+ FOR_EACH_OBSERVER(ExperimentalBluetoothDeviceClient::Observer,
+ observers_,
DeviceAdded(object_path));
}
// Called by dbus::ObjectManager when an object with the device interface
// is removed. Informs observers.
- void ObjectRemoved(const dbus::ObjectPath& object_path,
- const std::string& interface_name) OVERRIDE {
- FOR_EACH_OBSERVER(ExperimentalBluetoothDeviceClient::Observer, observers_,
+ virtual void ObjectRemoved(const dbus::ObjectPath& object_path,
+ const std::string& interface_name) OVERRIDE {
+ FOR_EACH_OBSERVER(ExperimentalBluetoothDeviceClient::Observer,
+ observers_,
DeviceRemoved(object_path));
}
« no previous file with comments | « chromeos/dbus/experimental_bluetooth_adapter_client.cc ('k') | chromeos/display/output_configurator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698