Rename Node::attached() to confusingAndOftenMisusedAttached()

Rename Node::attached() to confusingAndOftenMisusedAttached()

According to Elliot's talk at BlinkOn, the attached() function is confusing and
often misused. We should call that out in the name while we audit all the callers.

Most callers want inDocument() && document().renderView() or just inDocument().
The ones inside the recalcStyle machinery probably need some kind of
styleChangeType() check.

R=esprehn
BUG=299011
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158403

[Hajime Morrita, 2013-09-26 20:53:22]

It might be helpful to inform readers how it is confusing and can be misused.
Having notes, links either in the commit log or in the comment will help us
much.

[Hajime Morrita, 2013-09-26 20:53:38]

lgtm anyway.

[abarth-chromium, 2013-09-26 20:57:13]

On 2013/09/26 20:53:22, morrita1 wrote:
> It might be helpful to inform readers how it is confusing and can be misused.
> Having notes, links either in the commit log or in the comment will help us
> much.

My understanding is that the notion of "attached" doesn't mean anything.  For
example, we set the bit even when lazily attaching the node.  Elliot said that
most callers want to call inDocument instead.  Maybe Elliot can comment more.

[esprehn, 2013-09-26 20:58:20]

Haha, I suppose we could go with deprecatedAttached() but marking them to burn
down is good.

Most callers want inDocument() && document().renderView() or just inDocument().
The ones inside the recalcStyle machinery probably need some kind of
styleChangeType() check.

[esprehn, 2013-09-26 20:58:43]

lgtm

[abarth-chromium, 2013-09-26 21:37:51]

I left the long name because it's more fun.  :)

I also added Elliot's comments to the description so they'll show up in the
commit log.

[commit-bot: I haz the power, 2013-09-26 21:39:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/24773003/1

[commit-bot: I haz the power, 2013-09-26 23:16:32]

Change committed as 158403