Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: Source/core/dom/Node.h

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/FullscreenElementStack.cpp ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Node.h
diff --git a/Source/core/dom/Node.h b/Source/core/dom/Node.h
index 612111edf4b6dd97198ca1f739da9e8a177cef16..ab4310c57f35adfdbfd6568e6df5ca7bb43f6d73 100644
--- a/Source/core/dom/Node.h
+++ b/Source/core/dom/Node.h
@@ -365,7 +365,7 @@ public:
bool hovered() const { return isUserActionElement() && isUserActionElementHovered(); }
bool focused() const { return isUserActionElement() && isUserActionElementFocused(); }
- bool attached() const { return getFlag(IsAttachedFlag); }
+ bool confusingAndOftenMisusedAttached() const { return getFlag(IsAttachedFlag); }
void setAttached() { setFlag(IsAttachedFlag); }
bool needsStyleRecalc() const { return styleChangeType() != NoStyleChange; }
StyleChangeType styleChangeType() const { return static_cast<StyleChangeType>(m_nodeFlags & StyleChangeMask); }
@@ -905,7 +905,7 @@ inline ContainerNode* Node::parentNodeGuaranteedHostFree() const
inline void Node::lazyReattachIfAttached()
{
- if (attached())
+ if (confusingAndOftenMisusedAttached())
lazyReattach();
}
@@ -917,7 +917,7 @@ inline void Node::lazyReattach()
AttachContext context;
context.performingReattach = true;
- if (attached())
+ if (confusingAndOftenMisusedAttached())
detach(context);
lazyAttach();
}
« no previous file with comments | « Source/core/dom/FullscreenElementStack.cpp ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698