Source/core/svg/SVGTests.cpp - Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGTests.cpp

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGTests.cpp

diff --git a/Source/core/svg/SVGTests.cpp b/Source/core/svg/SVGTests.cpp

index 2c309550176b7c96257170bd4ae5fefd2ac57a14..9966ba625ada40067b212f6e2dd84979253de94f 100644

--- a/Source/core/svg/SVGTests.cpp

+++ b/Source/core/svg/SVGTests.cpp

@@ -155,9 +155,9 @@ bool SVGTests::handleAttributeChange(SVGElement* targetElement, const QualifiedN

return true;

bool valid = targetElement->isValid();

- if (valid && !targetElement->attached() && targetElement->parentNode()->attached())

+ if (valid && !targetElement->confusingAndOftenMisusedAttached() && targetElement->parentNode()->confusingAndOftenMisusedAttached())

targetElement->lazyAttach();

- else if (!valid && targetElement->attached())

+ else if (!valid && targetElement->confusingAndOftenMisusedAttached())

targetElement->detach();

return true;

« no previous file with comments | « Source/core/rendering/RenderMenuList.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »