Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: Source/core/testing/Internals.cpp

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGUseElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 return toShadowRoot(root)->childShadowRootCount(); 487 return toShadowRoot(root)->childShadowRootCount();
488 } 488 }
489 489
490 bool Internals::attached(Node* node, ExceptionState& es) 490 bool Internals::attached(Node* node, ExceptionState& es)
491 { 491 {
492 if (!node) { 492 if (!node) {
493 es.throwUninformativeAndGenericDOMException(InvalidAccessError); 493 es.throwUninformativeAndGenericDOMException(InvalidAccessError);
494 return false; 494 return false;
495 } 495 }
496 496
497 return node->attached(); 497 return node->confusingAndOftenMisusedAttached();
498 } 498 }
499 499
500 Node* Internals::nextSiblingByWalker(Node* node, ExceptionState& es) 500 Node* Internals::nextSiblingByWalker(Node* node, ExceptionState& es)
501 { 501 {
502 if (!node) { 502 if (!node) {
503 es.throwUninformativeAndGenericDOMException(InvalidAccessError); 503 es.throwUninformativeAndGenericDOMException(InvalidAccessError);
504 return 0; 504 return 0;
505 } 505 }
506 ComposedTreeWalker walker(node); 506 ComposedTreeWalker walker(node);
507 walker.nextSibling(); 507 walker.nextSibling();
(...skipping 1743 matching lines...) Expand 10 before | Expand all | Expand 10 after
2251 return false; 2251 return false;
2252 sharedContext->extensions()->loseContextCHROMIUM(Extensions3D::GUILTY_CONTEX T_RESET_ARB, Extensions3D::INNOCENT_CONTEXT_RESET_ARB); 2252 sharedContext->extensions()->loseContextCHROMIUM(Extensions3D::GUILTY_CONTEX T_RESET_ARB, Extensions3D::INNOCENT_CONTEXT_RESET_ARB);
2253 // To prevent tests that call loseSharedGraphicsContext3D from being 2253 // To prevent tests that call loseSharedGraphicsContext3D from being
2254 // flaky, we call finish so that the context is guaranteed to be lost 2254 // flaky, we call finish so that the context is guaranteed to be lost
2255 // synchronously (i.e. before returning). 2255 // synchronously (i.e. before returning).
2256 sharedContext->finish(); 2256 sharedContext->finish();
2257 return true; 2257 return true;
2258 } 2258 }
2259 2259
2260 } 2260 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGUseElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698