Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: Source/core/dom/shadow/ElementShadow.cpp

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Text.cpp ('k') | Source/core/dom/shadow/InsertionPoint.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/shadow/ElementShadow.cpp
diff --git a/Source/core/dom/shadow/ElementShadow.cpp b/Source/core/dom/shadow/ElementShadow.cpp
index bebad50f004c6fac391e15fd7854d459049a452c..cb05af34dadfa675e0de348e59f090652b56a4a4 100644
--- a/Source/core/dom/shadow/ElementShadow.cpp
+++ b/Source/core/dom/shadow/ElementShadow.cpp
@@ -85,7 +85,7 @@ void ElementShadow::removeAllShadowRoots()
InspectorInstrumentation::willPopShadowRoot(shadowHost, oldRoot.get());
shadowHost->document().removeFocusedElementOfSubtree(oldRoot.get());
- if (oldRoot->attached())
+ if (oldRoot->confusingAndOftenMisusedAttached())
oldRoot->detach();
m_shadowRoots.removeHead();
@@ -103,7 +103,7 @@ void ElementShadow::attach(const Node::AttachContext& context)
childrenContext.resolvedStyle = 0;
for (ShadowRoot* root = youngestShadowRoot(); root; root = root->olderShadowRoot()) {
- if (!root->attached())
+ if (!root->confusingAndOftenMisusedAttached())
root->attach(childrenContext);
}
}
@@ -114,7 +114,7 @@ void ElementShadow::detach(const Node::AttachContext& context)
childrenContext.resolvedStyle = 0;
for (ShadowRoot* root = youngestShadowRoot(); root; root = root->olderShadowRoot()) {
- if (root->attached())
+ if (root->confusingAndOftenMisusedAttached())
root->detach(childrenContext);
}
}
« no previous file with comments | « Source/core/dom/Text.cpp ('k') | Source/core/dom/shadow/InsertionPoint.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698