Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: Source/core/html/shadow/MediaControlElementTypes.cpp

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/shadow/MediaControlElementTypes.cpp
diff --git a/Source/core/html/shadow/MediaControlElementTypes.cpp b/Source/core/html/shadow/MediaControlElementTypes.cpp
index 29d161e86f90f23c6331463d6cf2a0ffaccb5ff8..6352638b9f86cbb36ad9cbc20be5b305ed40115a 100644
--- a/Source/core/html/shadow/MediaControlElementTypes.cpp
+++ b/Source/core/html/shadow/MediaControlElementTypes.cpp
@@ -175,7 +175,7 @@ void MediaControlVolumeSliderElement::defaultEventHandler(Event* event)
if (event->isMouseEvent() && toMouseEvent(event)->button())
return;
- if (!attached())
+ if (!confusingAndOftenMisusedAttached())
return;
MediaControlInputElement::defaultEventHandler(event);
@@ -192,7 +192,7 @@ void MediaControlVolumeSliderElement::defaultEventHandler(Event* event)
bool MediaControlVolumeSliderElement::willRespondToMouseMoveEvents()
{
- if (!attached())
+ if (!confusingAndOftenMisusedAttached())
return false;
return MediaControlInputElement::willRespondToMouseMoveEvents();
@@ -200,7 +200,7 @@ bool MediaControlVolumeSliderElement::willRespondToMouseMoveEvents()
bool MediaControlVolumeSliderElement::willRespondToMouseClickEvents()
{
- if (!attached())
+ if (!confusingAndOftenMisusedAttached())
return false;
return MediaControlInputElement::willRespondToMouseClickEvents();
« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698