Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: Source/core/dom/NodeRenderingContext.cpp

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/dom/Range.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
7 * Copyright (C) 2011 Google Inc. All rights reserved. 7 * Copyright (C) 2011 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 return renderer; 78 return renderer;
79 } 79 }
80 return 0; 80 return 0;
81 } 81 }
82 82
83 if (m_parentFlowRenderer) 83 if (m_parentFlowRenderer)
84 return m_parentFlowRenderer->nextRendererForNode(m_node); 84 return m_parentFlowRenderer->nextRendererForNode(m_node);
85 85
86 // Avoid an O(N^2) problem with this function by not checking for 86 // Avoid an O(N^2) problem with this function by not checking for
87 // nextRenderer() when the parent element hasn't attached yet. 87 // nextRenderer() when the parent element hasn't attached yet.
88 if (m_renderingParent && !m_renderingParent->attached()) 88 if (m_renderingParent && !m_renderingParent->confusingAndOftenMisusedAttache d())
89 return 0; 89 return 0;
90 90
91 for (Node* sibling = NodeRenderingTraversal::nextSibling(m_node); sibling; s ibling = NodeRenderingTraversal::nextSibling(sibling)) { 91 for (Node* sibling = NodeRenderingTraversal::nextSibling(m_node); sibling; s ibling = NodeRenderingTraversal::nextSibling(sibling)) {
92 RenderObject* renderer = sibling->renderer(); 92 RenderObject* renderer = sibling->renderer();
93 if (renderer && !isRendererReparented(renderer)) 93 if (renderer && !isRendererReparented(renderer))
94 return renderer; 94 return renderer;
95 } 95 }
96 96
97 return 0; 97 return 0;
98 } 98 }
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 newRenderer->setFlowThreadState(parentRenderer->flowThreadState()); 277 newRenderer->setFlowThreadState(parentRenderer->flowThreadState());
278 278
279 RenderObject* nextRenderer = this->nextRenderer(); 279 RenderObject* nextRenderer = this->nextRenderer();
280 textNode->setRenderer(newRenderer); 280 textNode->setRenderer(newRenderer);
281 // Parent takes care of the animations, no need to call setAnimatableStyle. 281 // Parent takes care of the animations, no need to call setAnimatableStyle.
282 newRenderer->setStyle(m_style.release()); 282 newRenderer->setStyle(m_style.release());
283 parentRenderer->addChild(newRenderer, nextRenderer); 283 parentRenderer->addChild(newRenderer, nextRenderer);
284 } 284 }
285 285
286 } 286 }
OLDNEW
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/dom/Range.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698