Rename Node::attached() to confusingAndOftenMisusedAttached()

Source/core/page/DOMWindow.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 309 matching lines @@
     , m_shouldPrintWhenFinishedLoading(false)
 {
     ASSERT(frame);
     ScriptWrappable::init(this);
 }
 
 void DOMWindow::setDocument(PassRefPtr<Document> document)
 {
     ASSERT(!document || document->frame() == m_frame);
     if (m_document) {
-        if (m_document->attached()) {
+        if (m_document->confusingAndOftenMisusedAttached()) {
             // FIXME: We don't call willRemove here. Why is that OK?
             // This detach() call is also mostly redundant. Most of the calls to
             // this function come via DocumentLoader::createWriterFor, which
             // always detaches the previous Document first. Only XSLTProcessor
             // depends on this detach() call, so it seems like there's some room
             // for cleanup.
             m_document->detach();
         }
         m_document->setDOMWindow(0);
     }
 
     m_document = document;
 
     if (!m_document)
         return;
 
     m_document->setDOMWindow(this);
-    if (!m_document->attached())
+    if (!m_document->confusingAndOftenMisusedAttached())
         m_document->attach();
 
     if (!m_frame)
         return;
 
     m_frame->script()->updateDocument();
     m_document->updateViewportArguments();
 
     if (m_frame->page() && m_frame->view()) {
         if (ScrollingCoordinator* scrollingCoordinator = m_frame->page()->scrollingCoordinator()) {
@@ skipping 28 matching lines @@
     ASSERT(!m_location);
     ASSERT(!m_media);
     ASSERT(!m_sessionStorage);
     ASSERT(!m_localStorage);
     ASSERT(!m_applicationCache);
 
     reset();
 
     removeAllEventListeners();
 
-    ASSERT(!m_document->attached());
+    ASSERT(!m_document->confusingAndOftenMisusedAttached());
     setDocument(0);
 }
 
 const AtomicString& DOMWindow::interfaceName() const
 {
     return eventNames().interfaceForDOMWindow;
 }
 
 ScriptExecutionContext* DOMWindow::scriptExecutionContext() const
 {
@@ skipping 1353 matching lines @@
     return static_cast<DOMWindowLifecycleNotifier*>(LifecycleContext::lifecycleNotifier());
 }
 
 PassOwnPtr<LifecycleNotifier> DOMWindow::createLifecycleNotifier()
 {
     return DOMWindowLifecycleNotifier::create(this);
 }
 
 
 } // namespace WebCore